-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fan modes #28
Added fan modes #28
Conversation
Added fan allowed modes to be able to implement fan control in lyric integration.
The way it is currently it never passes mode, only fanMode.
Quick question @timmo001, I was trying to test the code changes I've made to the climate.py file in my lyric integration to enable fan control, but I'm still getting the error stating LyricDevice does not have a fan property, which is what this PR should have accomplished. I'm still new to pull requests etc. so just wondering how to go about getting my updated climate.py to access the updated aiolyric. Thanks in advance. |
@nprez83 , have you already updated the HA lyric integration to work with this? I was hacking at it until I saw this and wonder if maybe it's already been done. Thanks! |
Hi @amokrunner, I had the code ready to go, but wasn't able to implement it as the aiolyric version hadn't been yet bumped to include the changes above, so the properties associated with fan modes were not yet available for lyric objects. Not sure if the aiolyric version has gotten bumped to this yet or not. Here are the changes I had ready to implement. Happy to throw in a PR once we confirm that the aiolyric version has been updated. I looked at the changelogs for 2022.4-6 and did not see that change listed.
|
I just saw that 2022.7 comes with python 3.10, which I believe will have the updated version of aiolyric, including the changes related to fan modes. Once that happens I'll test out the changes I delineated above and will submit a PR. |
Proposed Changes
Related Issues
Checklist