-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable precompilation for selected packages via Preferences
#334
Conversation
Codecov ReportBase: 83.56% // Head: 83.57% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #334 +/- ##
==========================================
+ Coverage 83.56% 83.57% +0.01%
==========================================
Files 17 17
Lines 2184 2186 +2
==========================================
+ Hits 1825 1827 +2
Misses 359 359
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Hum, => restricted to julia 1.6+ |
I wonder if we should make it more complicated 🙂 . Specifically, would it be useful to allow one to specify a list of packages one shouldn't execute the precompile workload for? If I'm developing a specific package I still might want good precompilation on others. I'm happy to help with this. I was going to transfer SnoopPrecompile first but with this as a head-start there's probably no reason to do so. |
Good point , yes.
Done. E.g. in ~/.julia/environments/v1.9/LocalPreferences.toml
Do you have an idea for crafting a test for this ? |
Preferences
Preferences
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tweaked the docs since precompilation itself isn't disabled, we're just skipping the workload that results in "extra" precompilation.
As far as a test, one could perhaps use
@precompile_all_calls begin
global workload_ran = true
end
and check isdefined(SomeModule, :workload_ran) && SomeModule.workload_ran
.
Co-authored-by: Tim Holy <[email protected]>
Co-authored-by: Tim Holy <[email protected]>
dbf848f
to
2af9390
Compare
@timholy, can you cancel the previous They seem to hang and fill up the actions queue thus preventing running CI for most recent commits. |
Co-authored-by: Tim Holy <[email protected]>
Thanks so much! Ideally I want to try a PkgEval run before we release this, but we should get this out soon: this meets a real need! ❤️ |
Fix #324.
Fix #298.
Supersedes #299.