Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to FlameGraphs 1.0 #294

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Update to FlameGraphs 1.0 #294

merged 1 commit into from
Sep 1, 2022

Conversation

timholy
Copy link
Owner

@timholy timholy commented Sep 1, 2022

AbstractTrees has historically been included indirectly, but this package has
long added new methods to AbstractTrees functions. In retrospect, this was probably
a poor decision. In addition to updating compat, this makes AbstractTrees an
explicit dependency.

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Base: 85.91% // Head: 85.83% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (ae242a9) compared to base (f6ddda7).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
- Coverage   85.91%   85.83%   -0.09%     
==========================================
  Files          17       17              
  Lines        2102     2104       +2     
==========================================
  Hits         1806     1806              
- Misses        296      298       +2     
Impacted Files Coverage Δ
src/parcel_snoopi_deep.jl 89.79% <50.00%> (-0.20%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

AbstractTrees has historically been included indirectly, but this package has
long added new methods to AbstractTrees functions. In retrospect, this was probably
a poor decision. In addition to updating compat, this makes AbstractTrees an
explicit dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant