Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement more powerful tree-join, fix tests on Julia-1.8 #292

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

timholy
Copy link
Owner

@timholy timholy commented Aug 31, 2022

Julia-1.8 reports invalidations slightly differently from previous
versions. This harmonizes the output and avoids duplicating
trees/roots/branches.

While this suffices to fix SnoopCompile on 1.8, nightly will require additional work (failure anticipated).

Julia-1.8 reports invalidations slightly differently from previous
versions. This harmonizes the output and avoids duplicating
trees/roots/branches.
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Base: 80.24% // Head: 86.03% // Increases project coverage by +5.78% 🎉

Coverage data is based on head (365f218) compared to base (ccbafd6).
Patch coverage: 72.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #292      +/-   ##
==========================================
+ Coverage   80.24%   86.03%   +5.78%     
==========================================
  Files          17       17              
  Lines        1929     2098     +169     
==========================================
+ Hits         1548     1805     +257     
+ Misses        381      293      -88     
Impacted Files Coverage Δ
src/invalidations.jl 86.71% <72.50%> (+9.53%) ⬆️
SnoopCompileCore/src/snoopi_deep.jl 92.00% <0.00%> (-3.66%) ⬇️
SnoopPrecompile/src/SnoopPrecompile.jl 81.25% <0.00%> (-0.90%) ⬇️
src/parcel_snoopc.jl 78.15% <0.00%> (-0.23%) ⬇️
src/visualizations.jl 0.00% <0.00%> (ø)
src/parcel_snoopi.jl 94.14% <0.00%> (+0.30%) ⬆️
src/parcel_snoopl.jl 90.00% <0.00%> (+0.52%) ⬆️
src/write.jl 92.30% <0.00%> (+1.00%) ⬆️
src/deep_demos.jl 58.97% <0.00%> (+1.07%) ⬆️
src/parcel_snoopi_deep.jl 89.98% <0.00%> (+3.23%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timholy timholy merged commit e87fbe7 into master Aug 31, 2022
@timholy timholy deleted the teh/fix-1.8 branch August 31, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant