Fix MethodInstance multiplicity #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Formerly this seemed to return a single MethodInstance, but now it returns two. The change is may be from improvements to MethodAnalysis, likely timholy/MethodAnalysis.jl#27. The new behavior is certainly the correct one (there are two distinct methods, so there had better be two MethodInstances with that signature---even though one will never get another CodeInstance).
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
==========================================
- Coverage 86.95% 82.58% -4.37%
==========================================
Files 16 16
Lines 2023 1912 -111
==========================================
- Hits 1759 1579 -180
- Misses 264 333 +69
Continue to review full report at Codecov.
|
timholy
force-pushed
the
teh/fix_two_mis
branch
from
29b750d to
4a8d2cf
Compare
The answer on different Julia versions kept changing, so it's better to make the test more robust.
timholy
force-pushed
the
teh/fix_two_mis
branch
from
4a8d2cf to
53fb824
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formerly this seemed to return a single MethodInstance, but now it
returns two. The change may be from improvements to MethodAnalysis,
likely timholy/MethodAnalysis.jl#27.
The new behavior is certainly the correct one (there are two distinct
methods, so there had better be two MethodInstances with that
signature---even though one will never get another CodeInstance).