Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tests obsoleted by inference improvements #274

Merged
merged 2 commits into from
Jan 22, 2022

Conversation

timholy
Copy link
Owner

@timholy timholy commented Jan 22, 2022

Somebody keeps making inference better, messing up my tests. Geez! 😆

@timholy timholy force-pushed the teh/fix_nightly_snoopi branch from 22117fe to 9ed5b9d Compare January 22, 2022 13:57
@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #274 (28f7915) into master (3d34477) will increase coverage by 4.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #274      +/-   ##
==========================================
+ Coverage   82.47%   86.82%   +4.35%     
==========================================
  Files          16       16              
  Lines        1900     2012     +112     
==========================================
+ Hits         1567     1747     +180     
+ Misses        333      265      -68     
Impacted Files Coverage Δ
src/parcel_snoopc.jl 78.15% <0.00%> (-0.43%) ⬇️
src/visualizations.jl 0.00% <0.00%> (ø)
src/parcel_snoopi.jl 94.14% <0.00%> (+0.30%) ⬆️
SnoopCompileCore/src/snoopi_deep.jl 92.00% <0.00%> (+0.33%) ⬆️
src/parcel_snoopl.jl 90.00% <0.00%> (+0.52%) ⬆️
src/write.jl 92.30% <0.00%> (+1.00%) ⬆️
src/deep_demos.jl 58.97% <0.00%> (+1.07%) ⬆️
src/parcel_snoopi_deep.jl 89.54% <0.00%> (+1.82%) ⬆️
src/invalidations.jl 90.15% <0.00%> (+3.11%) ⬆️
src/invalidation_and_inference.jl 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d34477...28f7915. Read the comment docs.

@timholy timholy changed the title Skip a test obsoleted by inference improvements Skip tests obsoleted by inference improvements Jan 22, 2022
@timholy timholy merged commit 2ff6c69 into master Jan 22, 2022
@timholy timholy deleted the teh/fix_nightly_snoopi branch January 22, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant