Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve attribution of delayed invalidations #261

Merged
merged 8 commits into from
Aug 19, 2021

Conversation

timholy
Copy link
Owner

@timholy timholy commented Aug 19, 2021

Improves on #260 by collecting all callees and callers and then doing
the attribution at once (finding at least one identifiable callee).

Improves on #260 by collecting all callees and callers and then doing
the attribution at once (finding at least one identifiable callee).
@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #261 (d084c7e) into master (4e52869) will increase coverage by 1.61%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
+ Coverage   83.55%   85.16%   +1.61%     
==========================================
  Files          15       15              
  Lines        1800     1807       +7     
==========================================
+ Hits         1504     1539      +35     
+ Misses        296      268      -28     
Impacted Files Coverage Δ
src/invalidations.jl 88.39% <100.00%> (+8.45%) ⬆️
src/parcel_snoopi_deep.jl 87.81% <0.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e52869...d084c7e. Read the comment docs.

@timholy timholy merged commit 8b6bc60 into master Aug 19, 2021
@timholy timholy deleted the teh/better_delayed_attribution branch August 19, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant