Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor documentation improvements #254

Merged
merged 2 commits into from
Aug 11, 2021
Merged

Conversation

aviatesk
Copy link
Collaborator

While reading through the documentation, I found some words might look
nicer if they are codified (i.e. by enclosing them by backticks), mainly:

  • make sure to codify MethodInstance
  • if a package module is actually used, codify its name, e.g. SnoopCompile

Please tell me if you don't like these changes -- I don't mind simply
reverting that part.

Unrelated to above changes, I also added some typo fixes.

While reading through the documentation, I found some words might look
nicer if they are codified (i.e. by enclosing them by backticks), mainly:
- make sure to codify `MethodInstance`
- if a package module is actually used, codify its name, e.g. `SnoopCompile`

Please tell me if you don't like these changes -- I don't mind simply
reverting that part.

Unrelated to above, I also added some typo fixes.
Copy link
Owner

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great! Merge at will 🙂

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #254 (dca6f99) into master (1abf0a2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #254   +/-   ##
=======================================
  Coverage   85.06%   85.06%           
=======================================
  Files           9        9           
  Lines        1587     1587           
=======================================
  Hits         1350     1350           
  Misses        237      237           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1abf0a2...dca6f99. Read the comment docs.

@aviatesk aviatesk merged commit 87cb644 into timholy:master Aug 11, 2021
@aviatesk aviatesk deleted the avi/docs branch August 11, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants