Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @snoopl to reference docs #245

Merged
merged 1 commit into from
Jul 18, 2021
Merged

Conversation

NHDaly
Copy link
Collaborator

@NHDaly NHDaly commented Jul 12, 2021

I just noticed that @snoopl isn't in the documentation at all. I know it's not very widely used, but it'd be nice to refer to it here at least. :)

@snoopl was originally added in #135.

I just noticed that `@snoopl` isn't in the documentation at all. I know it's not very widely used, but it'd be nice to refer to it here at least. :)

`@snoopl` was originally added in #135.
@NHDaly NHDaly requested a review from timholy July 12, 2021 18:12
@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #245 (d4bae7c) into master (5ad2f24) will increase coverage by 0.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
+ Coverage   84.65%   85.29%   +0.64%     
==========================================
  Files           9        9              
  Lines        1590     1578      -12     
==========================================
  Hits         1346     1346              
+ Misses        244      232      -12     
Impacted Files Coverage Δ
src/parcel_snoopi.jl 93.77% <0.00%> (-0.89%) ⬇️
src/parcel_snoopi_deep.jl 88.07% <0.00%> (+0.81%) ⬆️
src/invalidations.jl 86.51% <0.00%> (+1.27%) ⬆️
src/parcel_snoopc.jl 78.37% <0.00%> (+1.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ad2f24...d4bae7c. Read the comment docs.

Copy link
Owner

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me! Some more documentation might increase its utility, but TBH I haven't played with it enough to know.

@NHDaly NHDaly merged commit 8ee47d0 into master Jul 18, 2021
@NHDaly NHDaly deleted the nhd-documentation-reference-snoopl branch July 18, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants