Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak for upcoming Core.Compiler change #671

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Conversation

aviatesk
Copy link
Collaborator

JuliaLang/julia#43800 will define new module EscapeAnalysis
inside Core.Compiler, and it requires this minor special handling.

@aviatesk
Copy link
Collaborator Author

Please do not merge this until we merge #43800.

@pfitzseb
Copy link
Collaborator

Should this just check for isdefined(Core.Compiler, :EscapeAnalysis)?

@aviatesk
Copy link
Collaborator Author

Right, we should have that static check also.

JuliaLang/julia#43800 will define new module `EscapeAnalysis`
inside `Core.Compiler`, and it requires this minor special handling.
@ianatol
Copy link
Contributor

ianatol commented Feb 16, 2022

@timholy Can this be merged? Revise.track(Core.Compiler) is broken on master without it (now that JuliaLang/julia#43800 is merged)

@timholy timholy merged commit b11e1a5 into timholy:master Feb 18, 2022
@timholy
Copy link
Owner

timholy commented Feb 18, 2022

@aviatesk do you want to make the new release? Just in case you know stuff that needs changing before we do that. I'm not running on the very latest master as I continue to work on getting JuliaLang/julia#43990 over the finish line.

@aviatesk aviatesk deleted the avi/EA branch February 18, 2022 14:58
@aviatesk
Copy link
Collaborator Author

It seems like JuliaInterpreter needs a bit more update to work on 1.8. We should probably wait for it to be updated before making the new release of Revise.

@simeonschaub
Copy link
Contributor

Why does this have to wait on JuliaInterpreter? Can we not just release this now since it seems to fix the failures I encountered on master?

@aviatesk
Copy link
Collaborator Author

@timholy Now Revise test suite runs successfully both on 1.7 and the very latest master, I'd like to ask you to publish the new release (maybe the patch one)?

@timholy
Copy link
Owner

timholy commented Feb 21, 2022

I don't know why CI is hanging on nightly, but I did just check that it works locally, so I'll tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants