-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tweak for upcoming Core.Compiler
change
#671
Conversation
Please do not merge this until we merge #43800. |
Should this just check for |
Right, we should have that static check also. |
JuliaLang/julia#43800 will define new module `EscapeAnalysis` inside `Core.Compiler`, and it requires this minor special handling.
@timholy Can this be merged? |
@aviatesk do you want to make the new release? Just in case you know stuff that needs changing before we do that. I'm not running on the very latest master as I continue to work on getting JuliaLang/julia#43990 over the finish line. |
It seems like JuliaInterpreter needs a bit more update to work on 1.8. We should probably wait for it to be updated before making the new release of Revise. |
Why does this have to wait on JuliaInterpreter? Can we not just release this now since it seems to fix the failures I encountered on master? |
@timholy Now Revise test suite runs successfully both on 1.7 and the very latest master, I'd like to ask you to publish the new release (maybe the patch one)? |
I don't know why CI is hanging on nightly, but I did just check that it works locally, so I'll tag. |
JuliaLang/julia#43800 will define new module
EscapeAnalysis
inside
Core.Compiler
, and it requires this minor special handling.