Support user-specified callbacks (v2) #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature is one half of what `Revise.entr` already does. The function `entr` allows the user to install callbacks for when a file or module changes, and also enters a blocking loop that catches any errors that might arise from the callbacks. This new `add_callback` function allows installing callbacks and keeping them around in the background. This commit also reimplements `entr` in terms of `add_callback` and `remove_callback`, and adds tests.
`Revise.track(mod)` is still called on the module, in case we're adding a callback for `Base` or an other package compiled in the system image.
|
This looks very good to me. Thanks for taking this home @ffevotte ! |
|
Thanks so much for doing this! Really excited to see this well fleshed-out. I notice that all the OSX tests passed, something that's been a little rare lately. I wonder if this may have fixed the annoying flakiness on OSX. I'll test in an additional PR. |
This was referenced May 24, 2020
This was referenced Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends and replaces #443, which it puts into a (hopefully) mergeable state:
CC: @timholy @tkluck