Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small reorganization to simplify porting Rebugger #218

Merged
merged 1 commit into from
Dec 30, 2018
Merged

Conversation

timholy
Copy link
Owner

@timholy timholy commented Dec 30, 2018

The new internal framework breaks Rebugger, but this makes it easier to update it.

The new internal framework breaks Rebugger, but this makes it easier to
update it.
@codecov
Copy link

codecov bot commented Dec 30, 2018

Codecov Report

Merging #218 into master will increase coverage by 0.01%.
The diff coverage is 48.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
+ Coverage   77.53%   77.55%   +0.01%     
==========================================
  Files          11       11              
  Lines        1024     1029       +5     
==========================================
+ Hits          794      798       +4     
- Misses        230      231       +1
Impacted Files Coverage Δ
src/recipes.jl 81.48% <100%> (ø) ⬆️
src/pkgs.jl 94.81% <100%> (ø) ⬆️
src/Revise.jl 65.48% <31.57%> (ø) ⬆️
src/utils.jl 48.88% <80%> (+3.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eae9201...c115199. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 30, 2018

Codecov Report

Merging #218 into master will increase coverage by 0.01%.
The diff coverage is 48.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
+ Coverage   77.53%   77.55%   +0.01%     
==========================================
  Files          11       11              
  Lines        1024     1029       +5     
==========================================
+ Hits          794      798       +4     
- Misses        230      231       +1
Impacted Files Coverage Δ
src/recipes.jl 81.48% <100%> (ø) ⬆️
src/pkgs.jl 94.81% <100%> (ø) ⬆️
src/Revise.jl 65.48% <31.57%> (ø) ⬆️
src/utils.jl 48.88% <80%> (+3.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eae9201...c115199. Read the comment docs.

@timholy timholy merged commit 09a3d35 into master Dec 30, 2018
@timholy timholy deleted the teh/rebugger branch December 30, 2018 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant