Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow switches between free and dev #217

Merged
merged 3 commits into from
Dec 29, 2018
Merged

Follow switches between free and dev #217

merged 3 commits into from
Dec 29, 2018

Conversation

timholy
Copy link
Owner

@timholy timholy commented Dec 29, 2018

Switching between free and dev has become my main reason to restart Julia, so it's finally time to fix #146.

This is a breaking change. When tagged this will become Revise version 1.0.0.

@codecov
Copy link

codecov bot commented Dec 29, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@4578264). Click here to learn what that means.
The diff coverage is 72.22%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #217   +/-   ##
=========================================
  Coverage          ?   76.49%           
=========================================
  Files             ?       11           
  Lines             ?     1021           
  Branches          ?        0           
=========================================
  Hits              ?      781           
  Misses            ?      240           
  Partials          ?        0
Impacted Files Coverage Δ
src/types.jl 92% <100%> (ø)
src/precompile.jl 100% <100%> (ø)
src/recipes.jl 50.63% <45.94%> (ø)
src/Revise.jl 64.79% <56.12%> (ø)
src/utils.jl 77.5% <77.5%> (ø)
src/pkgs.jl 93.26% <92.38%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4578264...24acdbb. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 29, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@4578264). Click here to learn what that means.
The diff coverage is 75.08%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #217   +/-   ##
=========================================
  Coverage          ?   77.53%           
=========================================
  Files             ?       11           
  Lines             ?     1024           
  Branches          ?        0           
=========================================
  Hits              ?      794           
  Misses            ?      230           
  Partials          ?        0
Impacted Files Coverage Δ
src/types.jl 96% <100%> (ø)
src/precompile.jl 100% <100%> (ø)
src/utils.jl 45% <45%> (ø)
src/Revise.jl 65.48% <62.62%> (ø)
src/recipes.jl 81.48% <82.92%> (ø)
src/pkgs.jl 94.81% <93.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4578264...b76ae7c. Read the comment docs.

This brings Revise into better concordance with Pkg and the way code-loading
works in Base. By using relative paths, we pave the way for relocating the
collection of files, for example when switching environments or between `free`
and `dev` modes.

This is not breaking in terms of exported interface, but any packages
that use Revise's internals may need modification.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise should "follow" files that go from add->dev
1 participant