Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement isinteger #34

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Implement isinteger #34

merged 1 commit into from
Jun 6, 2023

Conversation

MilesCranmer
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0372844) 94.64% compared to head (bf12330) 94.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #34   +/-   ##
=======================================
  Coverage   94.64%   94.64%           
=======================================
  Files           2        2           
  Lines          56       56           
=======================================
  Hits           53       53           
  Misses          3        3           
Impacted Files Coverage Δ
src/Ratios.jl 93.87% <100.00%> (+0.12%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timholy timholy merged commit 7dc203e into timholy:master Jun 6, 2023
@MilesCranmer MilesCranmer deleted the patch-1 branch June 6, 2023 15:37
@timholy
Copy link
Owner

timholy commented Jun 7, 2023

FYI the only reason this hasn't been released yet is because TagBot seems to not be working; I'd like to generate the tag for 0.4.4 (0372844) before releasing 0.4.5. Any ideas?

@MilesCranmer
Copy link
Contributor Author

Very weird. I’m not sure.

@MilesCranmer
Copy link
Contributor Author

You can generate it from the releases page manually right?

@timholy
Copy link
Owner

timholy commented Jun 7, 2023

I've not done that before, but yes, that does seem viable. I was just hoping for the nice summary of changes that TagBot generates.

@timholy
Copy link
Owner

timholy commented Jun 7, 2023

Let's see if anyone else can figure it out: https://julialang.slack.com/archives/C6M4DQA5P/p1686139618274699

@MilesCranmer
Copy link
Contributor Author

I was just hoping for the nice summary of changes that TagBot generates.

You can get this without TagBot too. If you go to releases: https://github.com/timholy/Ratios.jl/releases, and draft a new release, there will be a "generate release notes". Type the tag name you want and select the particular commit to tag, and it will create the tag when you publish the release.

@MilesCranmer
Copy link
Contributor Author

Here:
Screenshot 2023-06-07 at 8 22 30 AM

(This is the same notes that TagBot generates)

@timholy
Copy link
Owner

timholy commented Jun 13, 2023

TIL! Thanks so much, I had no idea this was possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants