Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use an extension for FixedPointNumbers #32

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

KristofferC
Copy link
Contributor

Before (in a temp env):

julia> @time using FixedPointNumbers
  0.074205 seconds (77.63 k allocations: 4.738 MiB)

julia> @time using Ratios
  0.412248 seconds (46.21 k allocations: 3.182 MiB, 7.24% compilation time)

After:

julia> @time using FixedPointNumbers
  0.023623 seconds (78.35 k allocations: 4.792 MiB)

julia> @time using Ratios
  0.008980 seconds (7.18 k allocations: 494.305 KiB, 28.47% compilation time)

julia> Base.get_extension(Ratios, :RatiosFixedPointNumbersExt)
RatiosFixedPointNumbersExt

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage: 88.88% and project coverage change: -1.66 ⚠️

Comparison is base (9f10d87) 96.29% compared to head (10b24c6) 94.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   96.29%   94.64%   -1.66%     
==========================================
  Files           1        2       +1     
  Lines          54       56       +2     
==========================================
+ Hits           52       53       +1     
- Misses          2        3       +1     
Impacted Files Coverage Δ
src/Ratios.jl 93.75% <0.00%> (-2.55%) ⬇️
ext/RatiosFixedPointNumbersExt.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timholy
Copy link
Owner

timholy commented Apr 24, 2023

I think we can safely go to Ratios 1.0 and drop support for Julia 0.7 😆 .

@KristofferC
Copy link
Contributor Author

I think we can safely go to Ratios 1.0

Well, that would require quite a bit of churn downstreams. Isn't it easier to just drop it and still make a patch release?

@timholy
Copy link
Owner

timholy commented Apr 24, 2023

I think the policy is you can't register a new version that changes the Julia compat without doing a point release. And since this is still in the 0.x cycle, that means the same churn regardless of whether we go to 0.5 or 1.0.

But perhaps an easier way would be to allow older versions of FixedPointNumbers? The log seems to suggest that 0.5 is installable on Julia 0.7.

@KristofferC
Copy link
Contributor Author

KristofferC commented Apr 24, 2023

I think the policy is you can't register a new version that changes the Julia compat without doing a point release

I don't think that is true, at least not for pre 1.0 stuff.

But I will just extend the compat then.

@KristofferC
Copy link
Contributor Author

Need approval to run the workflow again it seems.

@timholy
Copy link
Owner

timholy commented Apr 25, 2023

"@GitHub, KristofferC always has my approval"

Hmm, didn't work.

@KristofferC
Copy link
Contributor Author

No one left behind

@timholy timholy merged commit 3338494 into timholy:master Apr 25, 2023
@KristofferC KristofferC deleted the kc/extension branch April 25, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants