-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use an extension for FixedPointNumbers #32
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #32 +/- ##
==========================================
- Coverage 96.29% 94.64% -1.66%
==========================================
Files 1 2 +1
Lines 54 56 +2
==========================================
+ Hits 52 53 +1
- Misses 2 3 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
I think we can safely go to Ratios 1.0 and drop support for Julia 0.7 😆 . |
Well, that would require quite a bit of churn downstreams. Isn't it easier to just drop it and still make a patch release? |
I think the policy is you can't register a new version that changes the Julia compat without doing a point release. And since this is still in the 0.x cycle, that means the same churn regardless of whether we go to 0.5 or 1.0. But perhaps an easier way would be to allow older versions of FixedPointNumbers? The log seems to suggest that 0.5 is installable on Julia 0.7. |
I don't think that is true, at least not for pre 1.0 stuff. But I will just extend the compat then. |
Need approval to run the workflow again it seems. |
" Hmm, didn't work. |
No one left behind |
Before (in a temp env):
After: