Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mi.specialization::MethodInstance #38

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Conversation

timholy
Copy link
Owner

@timholy timholy commented Mar 23, 2023

This is such an easy fix, we might as well just do it here.

CC @vtjnash

This is such an easy fix, we might as well just do it here.
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +5.25 🎉

Comparison is base (37492ce) 89.33% compared to head (6d3580b) 94.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   89.33%   94.58%   +5.25%     
==========================================
  Files           4        4              
  Lines         403      406       +3     
==========================================
+ Hits          360      384      +24     
+ Misses         43       22      -21     
Impacted Files Coverage Δ
src/visit.jl 93.00% <100.00%> (+5.77%) ⬆️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM. Note there is no reason to visit :invokes currently, since they will all be in specializations

@timholy timholy merged commit 909c450 into master Mar 23, 2023
@timholy timholy deleted the teh/fix_nightly branch March 23, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants