-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hard dependency on FileIO.jl #67
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #67 +/- ##
==========================================
+ Coverage 94.91% 95.73% +0.81%
==========================================
Files 5 6 +1
Lines 354 375 +21
==========================================
+ Hits 336 359 +23
+ Misses 18 16 -2 ☔ View full report in Codecov by Sentry. |
144598b
to
629a7b6
Compare
Would you be OK with waiting for a release that contains your other fixes, and then we make a 1.1.0 release that makes Julia 1.10 (the future LTS) the minimum Julia version? That way we wouldn't need Requires.jl. EDIT: actually, it looks like all the changes since the last release are invisible to users. So we could just do this now, I think. Unless you really need to decouple FileIO for older versions of Julia? |
My main aim is to decouple However, I personally do not like the idea of changing the lower bounds of the compat entries within a single major version. Of course, this is a matter of "philosophy", not one that takes precedence over the practical issue of maintenance costs. Since the usage of One concern is that the decoupling of |
For packages that are at least 1.x.x (i.e., "full semver"), the policy in General is that you can't bump the Julia [compat] bound without a new minor release. That's intended to leave room for bugfixes that apply to older Julia versions. Since a minor bump is for new features, I personally think it's OK if newer features only apply to the Julia versions you want to support. But I'm also fine with the Requires version. Feel free to merge when you feel ready. |
This is in preparation for issue #65.
Unlike Colors.jl, I believe it is possible to remove the hard dependency on FilesIO.jl in a compatible manner, i.e. in FlameGraphs.jl v1.
This is because
FilesIO
must be loaded in order to useFile{format "JLPROF"}
.For compatibility this depends on Requires.jl instead. However, it had already been in the dependencies indirectly via FileIO.jl.