Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement signatures_at #11

Merged
merged 1 commit into from
Mar 4, 2019
Merged

Implement signatures_at #11

merged 1 commit into from
Mar 4, 2019

Conversation

timholy
Copy link
Owner

@timholy timholy commented Mar 3, 2019

This allows one to find the methods defined by a particular block of code. One subtlety here is that multiple methods might be defined if the file/line combination points to a method with default arguments, keyword arguments, and the like. Note that not all of these methods are guaranteed to even have the same name.

I also contemplated calling this methods_at, but that can be obtained from signatures_at followed by call(s) to which (or better, whichtt in JuliaInterpreter). Since which is slow, I thought it would be better to return just the most essential information.

Closes #3.

@timholy timholy force-pushed the teh/signatures_at branch from 5363eb7 to 6178cb8 Compare March 3, 2019 14:04
@codecov
Copy link

codecov bot commented Mar 3, 2019

Codecov Report

Merging #11 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #11   +/-   ##
====================================
  Coverage       0%    0%           
====================================
  Files           3     3           
  Lines          76   101   +25     
====================================
- Misses         76   101   +25
Impacted Files Coverage Δ
src/utils.jl 0% <0%> (ø) ⬆️
src/CodeTracking.jl 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16b061a...6178cb8. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 3, 2019

Codecov Report

Merging #11 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #11   +/-   ##
====================================
  Coverage       0%    0%           
====================================
  Files           3     3           
  Lines          76   102   +26     
====================================
- Misses         76   102   +26
Impacted Files Coverage Δ
src/utils.jl 0% <0%> (ø) ⬆️
src/CodeTracking.jl 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16b061a...008cd10. Read the comment docs.

@timholy
Copy link
Owner Author

timholy commented Mar 3, 2019

I'll wait a bit for folks to review this, but stuff is queued up behind it so...

@timholy timholy force-pushed the teh/signatures_at branch from 6178cb8 to 008cd10 Compare March 3, 2019 16:33
@timholy timholy merged commit 9f721f1 into master Mar 4, 2019
@timholy timholy deleted the teh/signatures_at branch March 4, 2019 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant