Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chart documentation #568

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Conversation

nhudson
Copy link
Contributor

@nhudson nhudson commented Aug 29, 2022

What this PR does / why we need it

We needed better documentation surrounding the chart installation and uninstallation process.

  • Add docs to make sure we recommend installing tobs to its own namespace
  • Add better uninstallation documentation and make sure everything is uninstalled
  • Updated Markdown formatting a bit...

Which issue this PR fixes

Checklist

@nhudson nhudson self-assigned this Aug 29, 2022
@nhudson nhudson requested a review from a team as a code owner August 29, 2022 22:57
@nhudson nhudson force-pushed the update_uninstall_docs branch from 84bbf71 to 44a12c3 Compare August 30, 2022 12:10
Copy link
Contributor

@paulfantom paulfantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version seems incorrect. Otherwise looks good.

chart/Chart.yaml Outdated Show resolved Hide resolved
chart/README.md Show resolved Hide resolved
@nhudson nhudson force-pushed the update_uninstall_docs branch from 44a12c3 to 1394548 Compare August 30, 2022 12:31
@nhudson nhudson requested a review from paulfantom August 30, 2022 12:31
@nhudson nhudson enabled auto-merge August 30, 2022 13:15
@nhudson nhudson merged commit 273f02c into timescale:main Aug 31, 2022
@nhudson nhudson deleted the update_uninstall_docs branch August 31, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants