Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import the UMASH hashing library #7616

Merged
merged 18 commits into from
Jan 24, 2025
Merged

Import the UMASH hashing library #7616

merged 18 commits into from
Jan 24, 2025

Conversation

akuzm
Copy link
Member

@akuzm akuzm commented Jan 23, 2025

We use it for vectorized hash grouping. For now, add the library separately to figure out the required CMake and CI changes.

Disable-check: force-changelog-file

We use it for vectorized hash grouping. For now, add the library
separately to figure out the required CMake.
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 529 lines in your changes missing coverage. Please review.

Project coverage is 81.34%. Comparing base (59f50f2) to head (1a4b797).
Report is 713 commits behind head on main.

Files with missing lines Patch % Lines
tsl/src/import/umash.c 0.00% 529 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7616      +/-   ##
==========================================
+ Coverage   80.06%   81.34%   +1.27%     
==========================================
  Files         190      240      +50     
  Lines       37181    44700    +7519     
  Branches     9450    11159    +1709     
==========================================
+ Hits        29770    36360    +6590     
- Misses       2997     3959     +962     
+ Partials     4414     4381      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akuzm akuzm marked this pull request as ready for review January 24, 2025 12:44
@akuzm akuzm enabled auto-merge (squash) January 24, 2025 14:44
@akuzm akuzm merged commit 2b0011e into timescale:main Jan 24, 2025
50 of 53 checks passed
@akuzm akuzm deleted the umash branch January 24, 2025 14:45
@akuzm akuzm mentioned this pull request Jan 29, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants