Fix flaky reorder regression test #7509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Execute manual `VACUUM` on the hypertable before reordering a chunk to avoid flaky test output.
fabriziomello
force-pushed
the
fix_flaky_reorder
branch
from
0a9f058 to
34b0c24
Compare
gayyappan
approved these changes
Dec 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7509 +/- ##
==========================================
+ Coverage 80.06% 82.16% +2.09%
==========================================
Files 190 230 +40
Lines 37181 43190 +6009
Branches 9450 10869 +1419
==========================================
+ Hits 29770 35486 +5716
- Misses 2997 3381 +384
+ Partials 4414 4323 -91 ☔ View full report in Codecov by Sentry. |
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Dec 13, 2024
In timescale#7509 we added manual VACUUM in all involved relations to avoid flaky output tests. But looks like it is not working very well specially on Windows builds, so now we're removing the output `found 0 removable, 0 nonremovable row versions in 0 pages` to have a more predictable output test. https://github.com/timescale/timescaledb/actions/runs/12322325859/job/34395659212?pr=7533#step:17:24
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Dec 16, 2024
In timescale#7509 we added manual VACUUM in all involved relations to avoid flaky output tests. But looks like it is not working very well specially on Windows builds, so now we're removing the output `found 0 removable, 0 nonremovable row versions in 0 pages` to have a more predictable output test. https://github.com/timescale/timescaledb/actions/runs/12322325859/job/34395659212?pr=7533#step:17:24
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Dec 16, 2024
In timescale#7509 we added manual VACUUM in all involved relations to avoid flaky output tests. But looks like it is not working very well specially on Windows builds, so now we're removing the output `found 0 removable, 0 nonremovable row versions in 0 pages` to have a more predictable output test. https://github.com/timescale/timescaledb/actions/runs/12322325859/job/34395659212?pr=7533#step:17:24
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Dec 16, 2024
In timescale#7509 we added manual VACUUM in all involved relations to avoid flaky output tests. But looks like it is not working very well specially on Windows builds, so now we're removing the output `found 0 removable, 0 nonremovable row versions in 0 pages` to have a more predictable output test. https://github.com/timescale/timescaledb/actions/runs/12322325859/job/34395659212?pr=7533#step:17:24
fabriziomello
added a commit
that referenced
this pull request
Dec 16, 2024
In #7509 we added manual VACUUM in all involved relations to avoid flaky output tests. But looks like it is not working very well specially on Windows builds, so now we're removing the output `found 0 removable, 0 nonremovable row versions in 0 pages` to have a more predictable output test. https://github.com/timescale/timescaledb/actions/runs/12322325859/job/34395659212?pr=7533#step:17:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execute manual
VACUUMon the hypertable before reordering a chunk to avoid flaky test output.Disable-check: force-changelog-file
Disable-check: approval-count