-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PG17: Enable ABI on CI #7312
PG17: Enable ABI on CI #7312
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7312 +/- ##
==========================================
+ Coverage 80.06% 82.22% +2.15%
==========================================
Files 190 217 +27
Lines 37181 38854 +1673
Branches 9450 10014 +564
==========================================
+ Hits 29770 31948 +2178
+ Misses 2997 2924 -73
+ Partials 4414 3982 -432 ☔ View full report in Codecov by Sentry. |
2a67297
to
3d81dff
Compare
105710f
to
f7e29ac
Compare
420d686
to
82edcf1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not fix the problem at all and just papers over it. ABI tests is a canary of future changes and we need to fix the cagg code to work with these.
Yep... I'm doing it in other PR: #7319 |
fe8ed04
to
a945db7
Compare
The new tzdata-2024b release introduced some changes on PST8PDT timezone using dates before 1970 so make sure to use dates starting in this year to avoid flaky tests. postgres/postgres@b8ea0f67
a945db7
to
66710f5
Compare
Also don't use dates before 1970 on regression tests since the new tzdata-2024b release introduced some changes on PST8PDT timezone using dates before 1970 so make sure to use dates starting in this year to avoid flaky tests.
postgres/postgres@b8ea0f67
Disable-check: force-changelog-file
Disable-check: commit-count