Don't disable batch sorted merge plan with enable_sort GUC #6330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nikkhils, @konskov: please review this pull request.
|
We have a separate GUC for it, this way it's more convenient to test various plans.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6330 +/- ##
==========================================
- Coverage 65.46% 65.40% -0.07%
==========================================
Files 249 249
Lines 57996 57953 -43
Branches 12919 12900 -19
==========================================
- Hits 37966 37902 -64
- Misses 18165 18210 +45
+ Partials 1865 1841 -24 ☔ View full report in Codecov by Sentry. |
svenklemm
approved these changes
Nov 20, 2023
jnidzwetzki
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a separate GUC for it, this way it's more convenient to test various plans.
Part of #6323
This can help with debugging problems like this one #6310
Disable-check: force-changelog-file