Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EXPLAIN ANALYZE for compressed DML #6210

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Fix EXPLAIN ANALYZE for compressed DML #6210

merged 1 commit into from
Oct 18, 2023

Conversation

svenklemm
Copy link
Member

@svenklemm svenklemm commented Oct 18, 2023 •
edited
Loading

EXPLAIN ANALYZE for compressed DML would error out with bogus varno error because we would modify the original expressions of the plan that were still referenced in nodes instead of adjusting copies and using those copies in our internal scans.

Fixes: #6175

@github-actions
Copy link

@gayyappan, @antekresic: please review this pull request.

Powered by pull-review

@svenklemm svenklemm requested a review from konskov October 18, 2023 09:22
@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

Merging #6210 (a9d0515) into main (a664e68) will decrease coverage by 0.03%.
Report is 4 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #6210      +/-   ##
==========================================
- Coverage   81.48%   81.45%   -0.03%     
==========================================
  Files         246      246              
  Lines       56978    56939      -39     
  Branches    12626    12610      -16     
==========================================
- Hits        46429    46382      -47     
+ Misses       8166     8147      -19     
- Partials     2383     2410      +27
Files Coverage Δ
tsl/src/compression/compression.c 91.63% <100.00%> (+0.12%) ⬆️

... and 46 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@svenklemm svenklemm changed the title Fix EXPLAIN for compressed DML Fix EXPLAIN ANALYZE for compressed DML Oct 18, 2023
@svenklemm
Fix EXPLAIN for compressed DML
a9d0515 
EXPLAIN ANALYZE for compressed DML would error out with `bogus varno`
error because we would modify the original expressions of the plan
that were still referenced in nodes instead of adjusting copies and
using those copies in our internal scans.
@svenklemm svenklemm enabled auto-merge (rebase) October 18, 2023 11:03
@svenklemm svenklemm merged commit 8f3bb0b into timescale:main Oct 18, 2023
36 checks passed
@timescale-automation
Copy link

Automated backport to 2.12.x not done: cherry-pick failed.

Git status

HEAD detached at origin/2.12.x
You are currently cherry-picking commit 8f3bb0ba7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   .unreleased/pr_6210
	modified:   tsl/src/compression/compression.c

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   tsl/test/shared/expected/decompress_tracking.out
	deleted by us:   tsl/test/shared/sql/decompress_tracking.sql

Job log

@timescale-automation timescale-automation added the auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts) label Oct 18, 2023
@horzsolt horzsolt added this to the TimescaleDB 2.12.2 milestone Oct 19, 2023
svenklemm added a commit to svenklemm/timescaledb that referenced this pull request Oct 19, 2023
@svenklemm
Release 2.12.2
65147bb 
This release contains bug fixes since the 2.12.1 release.
We recommend that you upgrade at the next available opportunity.

**Bugfixes**
* timescale#6155 Align gapfill bucket generation with time_bucket
* timescale#6210 Fix EXPLAIN ANALYZE for compressed DML
@svenklemm svenklemm mentioned this pull request Oct 19, 2023
Merged
svenklemm added a commit to svenklemm/timescaledb that referenced this pull request Oct 19, 2023
@svenklemm
Release 2.12.2
423c03f 
This release contains bug fixes since the 2.12.1 release.
We recommend that you upgrade at the next available opportunity.

**Bugfixes**
* timescale#6155 Align gapfill bucket generation with time_bucket
* timescale#6181 Ensure fixed_schedule field is populated
* timescale#6210 Fix EXPLAIN ANALYZE for compressed DML
svenklemm added a commit that referenced this pull request Oct 19, 2023
@svenklemm
Release 2.12.2
21a3ebd 
This release contains bug fixes since the 2.12.1 release.
We recommend that you upgrade at the next available opportunity.

**Bugfixes**
* #6155 Align gapfill bucket generation with time_bucket
* #6181 Ensure fixed_schedule field is populated
* #6210 Fix EXPLAIN ANALYZE for compressed DML
svenklemm added a commit to svenklemm/timescaledb that referenced this pull request Oct 19, 2023
@svenklemm
Release 2.12.2
48485af 
This release contains bug fixes since the 2.12.1 release.
We recommend that you upgrade at the next available opportunity.

**Bugfixes**
* timescale#6155 Align gapfill bucket generation with time_bucket
* timescale#6181 Ensure fixed_schedule field is populated
* timescale#6210 Fix EXPLAIN ANALYZE for compressed DML
@svenklemm svenklemm mentioned this pull request Oct 19, 2023
Merged
svenklemm added a commit that referenced this pull request Oct 19, 2023
@svenklemm
Release 2.12.2
2a39fbb 
This release contains bug fixes since the 2.12.1 release.
We recommend that you upgrade at the next available opportunity.

**Bugfixes**
* #6155 Align gapfill bucket generation with time_bucket
* #6181 Ensure fixed_schedule field is populated
* #6210 Fix EXPLAIN ANALYZE for compressed DML
jnidzwetzki pushed a commit to jnidzwetzki/timescaledb that referenced this pull request Nov 9, 2023
@svenklemm @jnidzwetzki
Release 2.12.2
8f30d4e 
This release contains bug fixes since the 2.12.1 release.
We recommend that you upgrade at the next available opportunity.

**Bugfixes**
* timescale#6155 Align gapfill bucket generation with time_bucket
* timescale#6181 Ensure fixed_schedule field is populated
* timescale#6210 Fix EXPLAIN ANALYZE for compressed DML
jnidzwetzki pushed a commit to jnidzwetzki/timescaledb that referenced this pull request Nov 19, 2023
@svenklemm @jnidzwetzki
Release 2.12.2
1350017 
This release contains bug fixes since the 2.12.1 release.
We recommend that you upgrade at the next available opportunity.

**Bugfixes**
* timescale#6155 Align gapfill bucket generation with time_bucket
* timescale#6181 Ensure fixed_schedule field is populated
* timescale#6210 Fix EXPLAIN ANALYZE for compressed DML
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konskov konskov konskov approved these changes

@akuzm akuzm akuzm approved these changes

@antekresic antekresic Awaiting requested review from antekresic

@gayyappan gayyappan Awaiting requested review from gayyappan

Assignees

@svenklemm svenklemm

Labels
auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts) backported-2.12.x
Projects
None yet
Milestone
TimescaleDB 2.12.2
Development

Successfully merging this pull request may close these issues.

[Bug]: EXPLAIN for UPDATE of compressed hypertable fails
5 participants
@svenklemm @timescale-automation @akuzm @konskov @horzsolt