Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to 2.11.x: #5990: Place data in first/last function in correct mctx #5993

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

timescale-automation
Copy link

This is an automated backport of #5990: Place data in first/last function in correct mctx.
This PR will be merged automatically after all the relevant CI checks pass. If this fix should not be backported, or will be backported manually, just close this PR. You can use the backport branch to add your changes, it won't be modified automatically anymore.

For more details, please see the documentation

Original description

Place data in first/last function in correct mctx

So far, the ts_bookend_deserializefunc() function has allocated the deserialized data in the current memory context. This data could be removed before the aggregation is finished. This patch moves the data into the aggregation memory context.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #5993 (3f25aaf) into 2.11.x (645c454) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           2.11.x    #5993      +/-   ##
==========================================
+ Coverage   90.95%   91.01%   +0.06%     
==========================================
  Files         230      230              
  Lines       54717    54712       -5     
==========================================
+ Hits        49767    49796      +29     
+ Misses       4950     4916      -34     
Files Changed Coverage Δ
src/agg_bookend.c 91.25% <100.00%> (+1.66%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

So far, the ts_bookend_deserializefunc() function has allocated the
deserialized data in the current memory context. This data could be
removed before the aggregation is finished. This patch moves the data
into the aggregation memory context.

(cherry picked from commit e998327)
@jnidzwetzki jnidzwetzki force-pushed the backport/2.11.x/5990 branch from da6996c to 3f25aaf Compare August 22, 2023 07:06
@timescale-automation timescale-automation merged commit 8a4a687 into 2.11.x Aug 22, 2023
@timescale-automation timescale-automation deleted the backport/2.11.x/5990 branch August 22, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is-auto-backport PR created by backport automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants