Fix missing result assignment for bms_del_member

This was causing memory corruption in the PG16 tests but affects previous PG versions as well.
timescale · Nov 3, 2023 · 4ed4e46 · 4ed4e46
1 parent 22b556d
commit 4ed4e46
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/.unreleased/pr_6264 b/.unreleased/pr_6264
@@ -0,0 +1 @@
+Fixes: #6264 Fix missing bms_del_member result assignment
diff --git a/tsl/src/nodes/decompress_chunk/batch_array.c b/tsl/src/nodes/decompress_chunk/batch_array.c
@@ -123,7 +123,8 @@ batch_array_get_free_slot(DecompressChunkState *chunk_state)
 	Assert(next_free_batch < chunk_state->n_batch_states);
 	Assert(TupIsNull(batch_array_get_at(chunk_state, next_free_batch)->decompressed_scan_slot));
 
-	bms_del_member(chunk_state->unused_batch_states, next_free_batch);
+	chunk_state->unused_batch_states =
+		bms_del_member(chunk_state->unused_batch_states, next_free_batch);
 
 	return next_free_batch;
 }
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fixes: #6264 Fix missing bms_del_member result assignment