Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pgx::prelude::* instead of pgx::* #586

Open
syvb opened this issue Oct 18, 2022 · 0 comments
Open

use pgx::prelude::* instead of pgx::* #586

syvb opened this issue Oct 18, 2022 · 0 comments

Comments

@syvb
Copy link
Member

syvb commented Oct 18, 2022

pgx 0.5.0 adds a prelude. Instead of importing pgx::* everywhere, we can now do use pgx::prelude::* instead and not import everything (importing everything pollutes the scope of the importer and makes it less clear where an item came from).

We should update Toolkit to use the prelude everywhere and remove all glob imports of pgx::*.

This was referenced Oct 18, 2022
syvb added a commit that referenced this issue Nov 15, 2022
pgx 0.6.0 will stop supporting `pgx::Datum`. `pg_sys::Datum` works with both
the current release and the upcoming 0.6.0 release. This also gets us closer
to using the pgx prelude (#586).
bors bot added a commit that referenced this issue Nov 17, 2022
618: Use pg_sys::Datum instead of pgx::Datum r=Smittyvb a=Smittyvb

pgx 0.6.0 will stop supporting the `pgx::Datum` import path. `pg_sys::Datum` works with both the current release and the upcoming 0.6.0 release.

This also gets us closer to [using the pgx prelude](#586).

Co-authored-by: Smitty <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant