Fix handling of FOREACH IN ARRAY

src/pgspot/visitors.py

@@ -160,6 +160,14 @@ def visit(self, node):
                             )
                         if "body" in value:
                             self.visit(value["body"])
+                    case "PLpgSQL_stmt_foreach_a":
+                        if "expr" in value:
+                            visit_sql(
+                                self.state,
+                                "SELECT " + value["expr"]["PLpgSQL_expr"]["query"],
+                            )
+                        if "body" in value:
+                            self.visit(value["body"])
                     case "PLpgSQL_stmt_raise":
                         if "params" in value:
                             for item in value["params"]:

testdata/expected/foreach_array.out

@@ -0,0 +1,4 @@
+PS016: Unqualified function call: format at line 1
+
+ Errors: 0 Warnings: 1 Unknown: 0 
+

testdata/foreach_array.sql

@@ -0,0 +1,12 @@
+DO LANGUAGE plpgsql $$
+DECLARE
+    desired_roles text[] := '{pg_checkpoint,pg_signal_backend,pg_read_all_stats,pg_stat_scan_tables}';
+    desired_role text;
+BEGIN
+    FOREACH desired_role IN ARRAY desired_roles LOOP
+        IF pg_catalog.to_regrole(desired_role) IS NOT NULL THEN
+            EXECUTE format('GRANT %I TO tsdbadmin', desired_role);
+        END IF;
+    END LOOP;
+END;
+$$;