Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pat: remove limit of one * in shell style #320

Merged
merged 4 commits into from
Jun 27, 2024
Merged

pat: remove limit of one * in shell style #320

merged 4 commits into from
Jun 27, 2024

Conversation

timbray
Copy link
Owner

@timbray timbray commented Jun 18, 2024

Note that this is a semantic change so will lead to release 1.1.0.

@timbray
Copy link
Owner Author

timbray commented Jun 19, 2024

The CI is breaking because "package slices is not in GOROOT". I just introduced slices in a test so I could use slices.Contains. I could easily take slices out and write my own "contains" method in about 3 minutes but I'm reluctant to do that without understanding what's going on. Is the "slices" package magically weird? Hey @embano1, any ideas?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.54%. Comparing base (e415ed3) to head (ee93bb5).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
+ Coverage   96.10%   96.54%   +0.44%     
==========================================
  Files          18       18              
  Lines        1744     1735       -9     
==========================================
- Hits         1676     1675       -1     
+ Misses         40       35       -5     
+ Partials       28       25       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timbray timbray requested review from yosiat, embano1, longzhang-lz and jsmorph and removed request for yosiat June 19, 2024 21:51
@timbray
Copy link
Owner Author

timbray commented Jun 27, 2024

OK, fairly obvious that nobody wants to review PRs that dive deep into finite-automaton wrangling. Will merge. Next PR is about getting numeric matching right, which at least is user-visible.

@timbray timbray merged commit 78e2ec8 into main Jun 27, 2024
7 checks passed
@timbray timbray deleted the issue-319 branch June 27, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants