fix lint complaints about case-fold builder (#348)

* fix lint complaints about case-fold builder

Signed-off-by: Tim Bray <[email protected]>

* missed some linting targets

Signed-off-by: Tim Bray <[email protected]>

* still more, need to update my local linter copy

Signed-off-by: Tim Bray <[email protected]>

---------

Signed-off-by: Tim Bray <[email protected]>

core_matcher_test.go

@@ -99,7 +99,7 @@ func TestExistsFalseOrder(t *testing.T) {
 		for _, match := range matches {
 			msg += fmt.Sprintf(" %s\n", match)
 		}
-		t.Errorf(msg)
+		t.Error(msg)
 	}
 }
 

generic_machine_test.go

@@ -83,23 +83,23 @@ func TestRulerNestedArrays(t *testing.T) {
 
 	r2, err := q.MatchesForEvent(event2)
 	if err != nil {
-		t.Errorf("Matches " + err.Error())
+		t.Error("Matches " + err.Error())
 	}
 	if len(r2) != 0 {
 		t.Errorf("r2 matchd %d", len(r2))
 	}
 
 	r3, err := q.MatchesForEvent(event3)
 	if err != nil {
-		t.Errorf("Matches " + err.Error())
+		t.Error("Matches " + err.Error())
 	}
 	if len(r3) != 0 {
 		t.Errorf("r3 matchd %d", len(r2))
 	}
 
 	r4, err := q.MatchesForEvent(event4)
 	if err != nil {
-		t.Errorf("Matches " + err.Error())
+		t.Error("Matches " + err.Error())
 	}
 	if len(r4) != 1 || r4[0] != "rule3" {
 		var msg string

pruner.go

@@ -98,10 +98,10 @@ type tooMuchFiltering struct {
 	MinAction         int64
 }
 
-func newTooMuchFiltering(ratio float64, min int64) *tooMuchFiltering {
+func newTooMuchFiltering(ratio float64, minimum int64) *tooMuchFiltering {
 	return &tooMuchFiltering{
 		FilteredToEmitted: ratio,
-		MinAction:         min,
+		MinAction:         minimum,
 	}
 }
 

quamina_test.go

@@ -166,7 +166,7 @@ func TestCityLots(t *testing.T) {
 			that is slower than the one the software was developed on, in which case you might want to readjust the
 			"thresholdPerformance" constant. However, it may be that you made a change that reduced the throughput of the
 			library, which would be unacceptable.`
-		t.Errorf(message1 + message2)
+		t.Error(message1 + message2)
 	}
 
 	if len(results) != len(wanted) {

rebuilding.go

@@ -15,10 +15,10 @@ type liveRatioTrigger struct {
 	MinLive int
 }
 
-func newLiveRatioTrigger(ratio float64, min int) *liveRatioTrigger {
+func newLiveRatioTrigger(ratio float64, minimum int) *liveRatioTrigger {
 	return &liveRatioTrigger{
 		Ratio:   ratio,
-		MinLive: min,
+		MinLive: minimum,
 	}
 }