-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat <title>, <script>, and <style> contents as text #69
Conversation
Tests look good! Looking forward to having these fixes in Fastboot. |
Btw. I didn’t implement the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for working on this!
Gonna leave this open for a little bit (ping me if you haven't heard back in a day or so) so @krisselden has a chance to review. |
@rwjblue friendly ping on this one. :D |
Released as https://github.com/tildeio/simple-html-tokenizer/releases/tag/v0.5.8 We'll need to bump the minimum version over in glimmerjs/glimmer-vm, and do a release. Does anyone have time to do that? |
@rwjblue Got a PR up for that glimmerjs/glimmer-vm#960, note that it ended up having some test failures in the VM. |
This looks like a breaking change, see prettier/prettier#6570 (comment) /cc @fisker |
@brodybits - Mind reporting an issue so we can discuss and track the path forward a bit easier? |
Sure, but there will not be limited detail until I get a chance to investigate it deeper. Hello from Providence. What cheer netop? |
Hello! 🎵 It's a small world after all... 🎵 😸 |
Fixes #21
This PR is one of the fixes that aim to improve <title>, <script>, and <style> support in Ember FastBoot (see: glimmerjs/glimmer-vm#796 (comment))
cc: @rwjblue