Don’t strip a newline after closing pre/textarea tags

tildeio · Jun 28, 2019 · e1b023b · e1b023b
1 parent 9a894bd
commit e1b023b
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 2 deletions.
diff --git a/src/evented-tokenizer.ts b/src/evented-tokenizer.ts
@@ -22,6 +22,7 @@ export default class EventedTokenizer {
   reset() {
     this.transitionTo(TokenizerState.beforeData);
     this.input = '';
+    this.tagNameBuffer = '';
 
     this.index = 0;
     this.line = 1;
@@ -124,10 +125,12 @@ export default class EventedTokenizer {
       } else {
         if (char === '\n') {
           let tag = this.tagNameBuffer.toLowerCase();
+
           if (tag === 'pre' || tag === 'textarea') {
             this.consume();
           }
         }
+
         this.transitionTo(TokenizerState.data);
         this.delegate.beginData();
       }
@@ -168,7 +171,7 @@ export default class EventedTokenizer {
     markupDeclarationOpen() {
       let char = this.consume();
 
-      if (char === '-' && this.input.charAt(this.index) === '-') {
+      if (char === '-' && this.peek() === '-') {
         this.consume();
         this.transitionTo(TokenizerState.commentStart);
         this.delegate.beginComment();
@@ -251,6 +254,24 @@ export default class EventedTokenizer {
       }
     },
 
+    endTagName() {
+      let char = this.consume();
+
+      if (isSpace(char)) {
+        this.transitionTo(TokenizerState.beforeAttributeName);
+        this.tagNameBuffer = '';
+      } else if (char === '/') {
+        this.transitionTo(TokenizerState.selfClosingStartTag);
+        this.tagNameBuffer = '';
+      } else if (char === '>') {
+        this.delegate.finishTag();
+        this.transitionTo(TokenizerState.beforeData);
+        this.tagNameBuffer = '';
+      } else {
+        this.appendToTagName(char);
+      }
+    },
+
     beforeAttributeName() {
       let char = this.peek();
 
@@ -453,7 +474,7 @@ export default class EventedTokenizer {
       let char = this.consume();
 
       if (char === '@' || char === ':' || isAlpha(char)) {
-        this.transitionTo(TokenizerState.tagName);
+        this.transitionTo(TokenizerState.endTagName);
         this.tagNameBuffer = '';
         this.delegate.beginEndTag();
         this.appendToTagName(char);

diff --git a/src/generated/tokenizer-states.ts b/src/generated/tokenizer-states.ts
@@ -12,6 +12,7 @@ export const enum TokenizerState {
   tagOpen = 'tagOpen',
   endTagOpen = 'endTagOpen',
   tagName = 'tagName',
+  endTagName = 'endTagName',
   rcdataLessThanSign = 'rcdataLessThanSign',
   rcdataEndTagOpen = 'rcdataEndTagOpen',
   rcdataEndTagName = 'rcdataEndTagName',

diff --git a/tests/tokenizer-tests.ts b/tests/tokenizer-tests.ts
@@ -205,6 +205,11 @@ QUnit.test('A newline immediately following a <pre> tag is stripped', function(a
   assert.deepEqual(tokens, [startTag('pre'), chars('hello'), endTag('pre')]);
 });
 
+QUnit.test('A newline immediately following a closing </pre> tag is not stripped', function(assert) {
+  let tokens = tokenize("\n<pre>\nhello</pre>\n");
+  assert.deepEqual(tokens, [chars('\n'), startTag('pre'), chars('hello'), endTag('pre'), chars('\n')]);
+});
+
 // https://html.spec.whatwg.org/multipage/syntax.html#element-restrictions
 QUnit.test('A newline immediately following a <PRE> tag is stripped', function(assert) {
   let tokens = tokenize("<PRE>\nhello</PRE>");