Make missing parameter error more descriptive #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariokostelac
commented
Mar 22, 2019
| if (missingParams.length > 0) { | ||
| throw new Error( | ||
| "You didn't provide enough string/numeric parameters to satisfy all of the dynamic segments for route ${name}." + | ||
| ' Missing params: ${missingParams}' |
There was a problem hiding this comment.
unfortunately linter thinks it's a good idea to put this line with single quotes even though previous one is double quoted.
While debugging some routing errors on deeply nested routes with many parameters, it became difficult to track what parameters were missing. This collects all missing parameters and adds that to the error message.
mariokostelac
force-pushed
the
mario/more_descriptive_error
branch
from
fbbdb68 to
1596570
Compare
rwjblue
approved these changes
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging some routing errors on deeply nested routes with many parameters, it became difficult to track what parameters were missing. This collects all missing parameters and adds that to the error message.