Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update reqwest to 0.9.5 #215

Merged
merged 6 commits into from
Dec 24, 2018
Merged

Update reqwest to 0.9.5 #215

merged 6 commits into from
Dec 24, 2018

Conversation

jonas-schievink
Copy link
Contributor

@jonas-schievink
Copy link
Contributor Author

CI fails due to rustfmt upgrade, let me know if I should run cargo fmt

@breezewish
Copy link
Member

Hmmm. Interesting. Stable failed but nightly succeeded, which means there will be different code format for the same code under different versions.. @overvenus What's your idea?

@kennytm
Copy link

kennytm commented Dec 11, 2018

@breeswish rustfmt is only executed on stable.

@breezewish
Copy link
Member

@kennytm Oh! sorry. I forgot that!

@jonas-schievink So maybe you can just run rustfmt to keep track with latest format spec (and pass CI 🤣).

@jonas-schievink
Copy link
Contributor Author

It is now failing because changes in clippy emit warnings, some of which inside generated code, which your CI is turning into errors.

@kennytm
Copy link

kennytm commented Dec 11, 2018

I suggest we fix the warnings for the two lints in lib.rs, and add #[cfg-attr(..., allow(clippy::renamed_and_removed_lints))] onto

https://github.com/pingcap/rust-prometheus/blob/2742561b84b70f8a623effd834d31c7bc5ce6bbd/src/lib.rs#L55-L57

until stepancheg/rust-protobuf#331 is resolved.

@jonas-schievink
Copy link
Contributor Author

jonas-schievink commented Dec 11, 2018 •
edited
Loading

Any #[allow] on the pub mod proto; seems to just be ignored

It works with #[allow(warnings)]

kennytm
kennytm reviewed Dec 11, 2018
View reviewed changes
breezewish
breezewish approved these changes Dec 12, 2018
View reviewed changes
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

siddontang
siddontang approved these changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@siddontang siddontang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kennytm
kennytm reviewed Dec 12, 2018
View reviewed changes
Copy link

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siddontang
Copy link
Contributor

Ping @breeswish

@breezewish breezewish merged commit 65a4f7d into tikv:master Dec 24, 2018
@fmckeogh fmckeogh mentioned this pull request Jan 14, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

@siddontang siddontang siddontang approved these changes

@breezewish breezewish breezewish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonas-schievink @breezewish @kennytm @siddontang