-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add subcompaction listener #218
Conversation
Signed-off-by: tabokie <[email protected]>
Signed-off-by: tabokie <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's it used for?
@Connor1996 Check this comment: #216 (comment), used for tagging subcompaction IO type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Status status; | ||
// the id of the thread that completed this compaction job. | ||
uint64_t thread_id; | ||
// the smallest input level of the compaction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add job_id so we can use it to match the CompactionJobInfo later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems job id is only unique within each background thread, that's why I removed it.
// the job id, which is unique in the same thread.
int job_id;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can put more thoughts on how to match subcompaction with main compaction later. Right now this PR covers our use case.
Add listener for subcompaction, only called when there are actually multiple subcompactions executed in parallel. Signed-off-by: tabokie <[email protected]>
Add listener for subcompaction, only called when there are actually multiple subcompactions executed in parallel. Signed-off-by: tabokie <[email protected]>
This reverts commit 2dfbfa5. Signed-off-by: tabokie <[email protected]>
Signed-off-by: tabokie [email protected]
Add listener for subcompaction, only called when there are actually multiple subcompactions executed in parallel.
Pass in
SubcompactionJobInfo
containing: