expose seqno from compaction filter and iterator #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: qupeng <[email protected]>
hicqu
force-pushed
the
compaction-filter-seqno
branch
from
d5e7bbb to
d827a00
Compare
hicqu
changed the title
Signed-off-by: qupeng <[email protected]>
hicqu
force-pushed
the
compaction-filter-seqno
branch
from
d827a00 to
2dcd150
Compare
yiwu-arbug
reviewed
Dec 8, 2020
yiwu-arbug
reviewed
Dec 8, 2020
| // Return the sequence number for the current entry if it's available. | ||
| // Return false if it's not available. | ||
| // REQUIRES: Valid() | ||
| virtual bool seqno(SequenceNumber* /*seqno*/) const { return false; } |
There was a problem hiding this comment.
do you need to update titan to support this method?
There was a problem hiding this comment.
It's not necessary because now we only use it for write CF, which its value is very small.
There was a problem hiding this comment.
Let's still update Titan. It sounds like a 坑 in the future.
Signed-off-by: qupeng <[email protected]>
Connor1996
approved these changes
Dec 8, 2020
tabokie
pushed a commit
to tabokie/rocksdb
that referenced
this pull request
May 12, 2022
This PR supports to access `seqno` for every key/value pairs in compaction filter or iterator. It's helpful to enhance GC in compaction filter in TiKV. Signed-off-by: qupeng <[email protected]> Signed-off-by: tabokie <[email protected]>
tabokie
pushed a commit
that referenced
this pull request
May 12, 2022
This PR supports to access `seqno` for every key/value pairs in compaction filter or iterator. It's helpful to enhance GC in compaction filter in TiKV. Signed-off-by: qupeng <[email protected]> Signed-off-by: tabokie <[email protected]>
v01dstar
pushed a commit
to v01dstar/rocksdb
that referenced
this pull request
Feb 21, 2024
This PR supports to access `seqno` for every key/value pairs in compaction filter or iterator. It's helpful to enhance GC in compaction filter in TiKV. Signed-off-by: qupeng <[email protected]> Signed-off-by: tabokie <[email protected]>
v01dstar
pushed a commit
to v01dstar/rocksdb
that referenced
this pull request
Feb 22, 2024
compaction_filter: add bottommost_level into context (tikv#160) Signed-off-by: qupeng <[email protected]> Signed-off-by: tabokie <[email protected]> add range for compaction filter context (tikv#192) * add range for compaction filter context Signed-off-by: qupeng <[email protected]> Signed-off-by: tabokie <[email protected]> allow no_io for VersionSet::GetTableProperties (tikv#211) * allow no_io for VersionSet::GetTableProperties Signed-off-by: qupeng <[email protected]> Signed-off-by: tabokie <[email protected]> expose seqno from compaction filter and iterator (tikv#215) This PR supports to access `seqno` for every key/value pairs in compaction filter or iterator. It's helpful to enhance GC in compaction filter in TiKV. Signed-off-by: qupeng <[email protected]> Signed-off-by: tabokie <[email protected]> allow to query DB stall status (tikv#226) This PR adds a new property is-write-stalled to query whether the column family is in write stall or not. In TiKV there is a compaction filter used for GC, in which DB::write is called. So if we can query whether the DB instance is stalled or not, we can skip to create more compaction filter instances to save some resources. Signed-off-by: qupeng <[email protected]> Signed-off-by: tabokie <[email protected]> Fix compatibilty issue with Titan Signed-off-by: v01dstar <[email protected]> filter deletion in compaction filter (tikv#344) And delay the buffer initialization of writable file to first actual write. --------- Signed-off-by: tabokie <[email protected]> Adjustments for compaptibilty with 8.10.facebook Signed-off-by: v01dstar <[email protected]> Adjust tikv related changes with upstream Signed-off-by: v01dstar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports to access
seqnofor every key/value pairs in compaction filter or iterator.It's helpful to enhance GC in compaction filter in TiKV.