Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update progress.committed_index for leader #375

Merged
merged 3 commits into from
Jun 15, 2020

Conversation

NingLin-P
Copy link
Member

@NingLin-P NingLin-P commented Jun 12, 2020

Signed-off-by: linning [email protected]

Do few thing for #366 :

  • update committed_index for leader

@NingLin-P NingLin-P requested review from BusyJay, hicqu and gengliqi June 12, 2020 08:12
@NingLin-P
Copy link
Member Author

PTAL @accelsao

src/progress/mod.rs Outdated Show resolved Hide resolved
src/raft.rs Outdated Show resolved Hide resolved
Signed-off-by: linning <[email protected]>
Signed-off-by: linning <[email protected]>
Copy link
Member

@gengliqi gengliqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gengliqi
Copy link
Member

The ci failed due to rust-lang/cargo#8353.

@NingLin-P NingLin-P merged commit 2d721a6 into tikv:master Jun 15, 2020
hicqu added a commit to hicqu/community that referenced this pull request Oct 21, 2020
Ning Lin (@NingLin-P) has done some fantastic works about
joint-consensus. Here is a PR list:

* tikv/raft-rs#375
* tikv/raft-rs#346
* tikv/tikv#8665
* tikv/tikv#8477
* tikv/tikv#8401
* tikv/tikv#8081
* tikv/tikv#7955
* tikv/tikv#7697

Based on this, we promote him to a committer of Raft-sig.
Congratulations!

Signed-off-by: qupeng <[email protected]>
ti-chi-bot pushed a commit to tikv/community that referenced this pull request Oct 30, 2020
* promote Ning Lin to a committer

Ning Lin (@NingLin-P) has done some fantastic works about
joint-consensus. Here is a PR list:

* tikv/raft-rs#375
* tikv/raft-rs#346
* tikv/tikv#8665
* tikv/tikv#8477
* tikv/tikv#8401
* tikv/tikv#8081
* tikv/tikv#7955
* tikv/tikv#7697

Based on this, we promote him to a committer of Raft-sig.
Congratulations!

Signed-off-by: qupeng <[email protected]>

* change to json

Signed-off-by: qupeng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants