Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update prost 0.11 #166

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Update prost 0.11 #166

merged 1 commit into from
Oct 25, 2022

Conversation

sticnarf
Copy link
Contributor

The generated file will contain a sha256. If profile.proto is not changed, we needn't regenerate the rust file. So, the users of the crate don't need protoc installed.

@sticnarf sticnarf force-pushed the prost-0.11 branch 4 times, most recently from 8774c80 to 9058410 Compare October 25, 2022 05:45
@sticnarf
update prost 0.11
54240a4 
Signed-off-by: Yilin Chen <[email protected]>
@sticnarf sticnarf marked this pull request as ready for review October 25, 2022 06:05
@sticnarf
Copy link
Contributor Author

Hi, @YangKeao . Now, I check in the generated prost file.

In build.rs, it uses SHA256 sum to decide whether we need to re-generate the prost file. Then, in most cases, the user does not need to install protoc to compile this crate.

YangKeao
YangKeao approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YangKeao YangKeao merged commit ada2c50 into tikv:master Oct 25, 2022
@alamb alamb mentioned this pull request Sep 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangKeao YangKeao YangKeao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sticnarf @YangKeao