Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dashboard): update TiDB Dashboard to v7.5.5-834dbcaf [release-7.5] #8911

Conversation

baurine
Copy link
Contributor

@baurine baurine commented Dec 12, 2024

What problem does this PR solve?

Issue Number: close #8913

Update TiDB Dashboard to v7.5.5-834dbcaf.

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. labels Dec 12, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 12, 2024

Hi @baurine. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 12, 2024
Signed-off-by: mornyx <[email protected]>
@mornyx
Copy link
Contributor

mornyx commented Dec 12, 2024

/retest

Copy link
Contributor

ti-chi-bot bot commented Dec 12, 2024

@mornyx: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rleungx
Copy link
Member

rleungx commented Dec 12, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. cherry-pick-approved Cherry pick PR approved by release team. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. do-not-merge/cherry-pick-not-approved labels Dec 12, 2024
@rleungx
Copy link
Member

rleungx commented Dec 12, 2024

/retest

3 similar comments
@mornyx
Copy link
Contributor

mornyx commented Dec 12, 2024

/retest

@mornyx
Copy link
Contributor

mornyx commented Dec 12, 2024

/retest

@mornyx
Copy link
Contributor

mornyx commented Dec 12, 2024

/retest

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.62%. Comparing base (aa647ec) to head (e18b275).
Report is 1 commits behind head on release-7.5.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-7.5    #8911      +/-   ##
===============================================
- Coverage        74.63%   74.62%   -0.01%     
===============================================
  Files              447      447              
  Lines            48435    48435              
===============================================
- Hits             36149    36146       -3     
+ Misses            9103     9098       -5     
- Partials          3183     3191       +8     
Flag Coverage Δ
unittests 74.62% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 13, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 13, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-13 02:57:45.942731153 +0000 UTC m=+580056.031533693: ☑️ agreed by rleungx.
  • 2024-12-13 04:35:42.636837721 +0000 UTC m=+585932.725640263: ☑️ agreed by JmPotato.

@ti-chi-bot ti-chi-bot bot merged commit e00e45b into tikv:release-7.5 Dec 13, 2024
25 checks passed
@mornyx mornyx deleted the update-tidb-dashboard/release-7.5-v7.5.5-834dbcaf-1733998766 branch December 13, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants