*: fix TestWatcher
#8812
*: fix TestWatcher
#8812
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
rleungx
force-pushed
the
fix-test-2024-33
branch
from
63b5f2b to
88de955
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8812 +/- ##
==========================================
+ Coverage 75.21% 75.25% +0.04%
==========================================
Files 459 456 -3
Lines 71843 71608 -235
==========================================
- Hits 54035 53887 -148
+ Misses 14351 14295 -56
+ Partials 3457 3426 -31
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
Signed-off-by: Ryan Leung <[email protected]>
rleungx
force-pushed
the
fix-test-2024-33
branch
from
88de955 to
967a861
Compare
|
/hold cancel |
ti-chi-bot
bot
removed
the
do-not-merge/hold
| @@ -357,6 +356,8 @@ func TestWatcher(t *testing.T) { | |||
| }, | |||
| }, | |||
| } | |||
| // wait watch to start | |||
| time.Sleep(time.Second) | |||
There was a problem hiding this comment.
Can we replace it with something like testutil.Eventually?
There was a problem hiding this comment.
seem we cannot get the watcher state outside
There was a problem hiding this comment.
We can use this way to control the messaging
There was a problem hiding this comment.
I think for this case, sleep is enough.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
approved
and removed
needs-1-more-lgtm
What problem does this PR solve?
Issue Number: Close #8549.
What is changed and how does it work?
Wait until the watcher finishes starting, then write the key.
Check List
Tests
Release note