Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mcs: change the log level #7654

Merged
merged 2 commits into from
Jan 3, 2024
Merged

mcs: change the log level #7654

merged 2 commits into from
Jan 3, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jan 3, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #7655.

What is changed and how does it work?

If there are some network problems, the service exists but pd cannot connect. It will print lots of logs.

Check List

Tests

  • Unit test

Release note

None.

@rleungx
change the log level
c678c19 
Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 3, 2024 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 3, 2024
@ti-chi-bot ti-chi-bot bot requested review from disksing and nolouch January 3, 2024 08:39
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 3, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT1 Indicates that a PR has LGTM 1. do-not-merge/needs-triage-completed labels Jan 3, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 3, 2024
@rleungx
Copy link
Member Author

rleungx commented Jan 3, 2024

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 3, 2024

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 3, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 6726c09

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 3, 2024
@ti-chi-bot ti-chi-bot bot merged commit baf4345 into tikv:master Jan 3, 2024
22 checks passed
@rleungx rleungx deleted the log-level branch January 3, 2024 09:05
pingandb pushed a commit to pingandb/pd that referenced this pull request Jan 18, 2024
@rleungx @pingandb
mcs: change the log level (tikv#7654)
bfb1ad3 
ref tikv#7655

Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: pingandb <[email protected]>
rleungx added a commit to rleungx/pd that referenced this pull request Jan 25, 2024
@lhy1024 @rleungx
mcs: fix unnecessary PDRedirectorHeader (tikv#7538) (tikv#247)
1de5d91 
* mcs: fix unnecessary PDRedirectorHeader (tikv#7538)

close tikv#7533

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: Ryan Leung <[email protected]>
Signed-off-by: lhy1024 <[email protected]>

* mcs: change the log level (tikv#7654)

ref tikv#7655

Signed-off-by: Ryan Leung <[email protected]>

* fix test

Signed-off-by: lhy1024 <[email protected]>

---------

Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Co-authored-by: Ryan Leung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

@CabinfeverB CabinfeverB CabinfeverB approved these changes

@disksing disksing Awaiting requested review from disksing

@nolouch nolouch Awaiting requested review from nolouch

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Too much logs when forwarding heartbeat if there are some network problems
3 participants
@rleungx @lhy1024 @CabinfeverB