Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swagger: block swagger url if disbale swagger server (#6785) #6789

Merged
merged 2 commits into from
Jul 14, 2023
Merged

swagger: block swagger url if disbale swagger server (#6785) #6789

merged 2 commits into from
Jul 14, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #6785

What problem does this PR solve?

Issue Number: Close #6786

What is changed and how does it work?

 /swagger/* return 404

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    Before
    curl xxxx:2379/swagger/ui/index
image

After
curl xxxx:2379/swagger/ui/index
image

swagger=1 make
image

Code changes

Side effects

Related changes

Release note

swagger: block swagger url if disbale swagger server

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 12, 2023
Merged
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 12, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • bufferflies

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jul 12, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 12, 2023
@ti-chi-bot ti-chi-bot bot requested review from nolouch and rleungx July 12, 2023 08:38
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 12, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 12, 2023
@bufferflies
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2023
@bufferflies
solve conflict
c96bae9 
Signed-off-by: bufferflies <[email protected]>
@bufferflies bufferflies force-pushed the cherry-pick-6785-to-release-6.5 branch from 76c4600 to c96bae9 Compare July 12, 2023 09:10
@codecov
Copy link

codecov bot commented Jul 12, 2023 •
edited
Loading

Codecov Report

Patch coverage: 40.00% and project coverage change: -0.01 ⚠️

Comparison is base (086871d) 75.59% compared to head (c96bae9) 75.59%.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-6.5    #6789      +/-   ##
===============================================
- Coverage        75.59%   75.59%   -0.01%     
===============================================
  Files              329      328       -1     
  Lines            33130    33128       -2     
===============================================
- Hits             25046    25043       -3     
- Misses            5931     5934       +3     
+ Partials          2153     2151       -2
Flag Coverage Δ
unittests 75.59% <40.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/cluster.go 78.47% <33.33%> (-0.53%) ⬇️
pkg/swaggerserver/swaggerserver_disable.go 50.00% <50.00%> (ø)

... and 28 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bufferflies
Copy link
Contributor

/test

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 12, 2023

@bufferflies: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test build

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 12, 2023
@bufferflies bufferflies removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2023
@bufferflies
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 12, 2023

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 12, 2023

This pull request has been accepted and is ready to merge.

Commit hash: c96bae9

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 12, 2023
@bufferflies
Copy link
Contributor

/test

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 12, 2023

@bufferflies: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test build

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 13, 2023

@HuSharp: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test build

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@HuSharp
Copy link
Member

HuSharp commented Jul 13, 2023

/test all

@bufferflies
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 13, 2023

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit f427242 into tikv:release-6.5 Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bufferflies bufferflies bufferflies approved these changes

@HuSharp HuSharp HuSharp approved these changes

@nolouch nolouch Awaiting requested review from nolouch

@rleungx rleungx Awaiting requested review from rleungx

Assignees

@bufferflies bufferflies

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @bufferflies @HuSharp