Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grcp_server: return err if cluster id is not ready . (#5412) #5425

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5412

Signed-off-by: bufferflies [email protected]

What problem does this PR solve?

Issue Number: Close #5411

What is changed and how does it work?

Check List

Tests

  • Unit test

  • Manual test (add detailed scripts or steps below)

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

None.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Aug 11, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Aug 11, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 11, 2022
Signed-off-by: bufferflies <[email protected]>
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #5425 (186ca2c) into release-6.1 (c91d5ca) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@               Coverage Diff               @@
##           release-6.1    #5425      +/-   ##
===============================================
- Coverage        75.45%   75.44%   -0.01%     
===============================================
  Files              307      307              
  Lines            30382    30387       +5     
===============================================
+ Hits             22925    22926       +1     
+ Misses            5466     5462       -4     
- Partials          1991     1999       +8     
Flag Coverage Δ
unittests 75.44% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/grpc_service.go 51.57% <0.00%> (-0.06%) ⬇️
pkg/errs/errs.go 75.00% <0.00%> (-25.00%) ⬇️
server/storage/kv/etcd_kv.go 79.71% <0.00%> (-5.80%) ⬇️
server/member/member.go 62.10% <0.00%> (-3.69%) ⬇️
pkg/etcdutil/etcdutil.go 85.05% <0.00%> (-3.45%) ⬇️
server/tso/tso.go 69.49% <0.00%> (-3.39%) ⬇️
server/region_syncer/server.go 82.06% <0.00%> (-1.09%) ⬇️
server/config/persist_options.go 93.23% <0.00%> (-0.72%) ⬇️
server/tso/allocator_manager.go 64.55% <0.00%> (-0.67%) ⬇️
server/cluster/coordinator.go 71.45% <0.00%> (-0.62%) ⬇️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 16, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 16, 2022
@bufferflies
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 186ca2c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 16, 2022
@ti-chi-bot ti-chi-bot merged commit 4ab9c0e into tikv:release-6.1 Aug 16, 2022
@jayl1e jayl1e added this to the v6.1.1 milestone Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants