Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: allow cancel load region (#4175) #4219

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4175

What problem does this PR solve?

Fix #3936

What is changed and how it works?

  • add cancel support for core.LoadRegion functions
  • replace chan bool with contextes in region syncer client
  • add test case

Check List

Tests

  • Unit test

Release note

Fix the issue that PD may not elect leader as soon as leader step down

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Oct 19, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-4.0 The PR belongs to release-4.0 cherry pick. labels Oct 19, 2021
Signed-off-by: disksing <[email protected]>
ref tikv#3936

Signed-off-by: disksing <[email protected]>
Signed-off-by: disksing <[email protected]>
Signed-off-by: disksing <[email protected]>
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #4219 (53bef99) into release-4.0 (b20ade2) will increase coverage by 0.56%.
The diff coverage is 93.18%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #4219      +/-   ##
===============================================
+ Coverage        74.82%   75.39%   +0.56%     
===============================================
  Files              211      211              
  Lines            20061    20061              
===============================================
+ Hits             15011    15125     +114     
+ Misses            3717     3609     -108     
+ Partials          1333     1327       -6     
Flag Coverage Δ
unittests 75.39% <93.18%> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/cluster/cluster.go 80.42% <0.00%> (+3.53%) ⬆️
server/core/storage.go 68.39% <75.00%> (+0.86%) ⬆️
server/region_syncer/client.go 79.68% <95.00%> (-2.67%) ⬇️
server/core/region_storage.go 80.23% <100.00%> (+1.75%) ⬆️
server/region_syncer/server.go 88.97% <100.00%> (+9.71%) ⬆️
server/schedulers/shuffle_hot_region.go 55.35% <0.00%> (-1.79%) ⬇️
server/member/lease.go 91.07% <0.00%> (-1.79%) ⬇️
server/grpc_service.go 58.66% <0.00%> (-1.21%) ⬇️
client/client.go 69.54% <0.00%> (-0.51%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b20ade2...53bef99. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 16, 2021
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 22, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 24, 2021
@nolouch
Copy link
Contributor

nolouch commented Nov 24, 2021

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 7ed160f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 24, 2021
@ti-chi-bot ti-chi-bot merged commit ae08ed0 into tikv:release-4.0 Nov 24, 2021
@zhouqiang-cl zhouqiang-cl added this to the v4.0.16 milestone Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-4.0 The PR belongs to release-4.0 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants