-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: allow empty region to be scheduled and use a sperate tolerance config in scatter range scheduler #4106
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #4106 +/- ##
==========================================
- Coverage 74.53% 74.46% -0.08%
==========================================
Files 258 258
Lines 26323 26334 +11
==========================================
- Hits 19621 19609 -12
- Misses 4963 4981 +18
- Partials 1739 1744 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…ance config in scatter range scheduler Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
/merge |
@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 03b045f
|
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created: #4116. |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created: #4117. |
In response to a cherrypick label: new pull request created: #4118. |
…ance config in scatter range scheduler (tikv#4106) * scheduler: allow empty region to be scheduled and use a sperate tolerance config in scatter range scheduler Signed-off-by: lhy1024 <[email protected]> * fix lint Signed-off-by: lhy1024 <[email protected]> * address comments Signed-off-by: lhy1024 <[email protected]> * fix lint Signed-off-by: lhy1024 <[email protected]> Co-authored-by: Ti Chi Robot <[email protected]>
…ance config in scatter range scheduler (#4106) (#4117) * schedulers: avoid recalculate tolerantRatio (#3745) * schedulers: avoid recalculate tolerantRatio Signed-off-by: disksing <[email protected]> * fix test Signed-off-by: disksing <[email protected]> Co-authored-by: Ti Chi Robot <[email protected]> * scheduler: allow empty region to be scheduled and use a sperate tolerance config in scatter range scheduler (#4106) * scheduler: allow empty region to be scheduled and use a sperate tolerance config in scatter range scheduler Signed-off-by: lhy1024 <[email protected]> * fix lint Signed-off-by: lhy1024 <[email protected]> * address comments Signed-off-by: lhy1024 <[email protected]> * fix lint Signed-off-by: lhy1024 <[email protected]> Co-authored-by: Ti Chi Robot <[email protected]> Co-authored-by: disksing <[email protected]> Co-authored-by: lhy1024 <[email protected]>
…ance config in scatter range scheduler (#4106) (#4118) * scheduler: allow empty region to be scheduled and use a sperate tolerance config in scatter range scheduler Signed-off-by: lhy1024 <[email protected]> * fix lint Signed-off-by: lhy1024 <[email protected]> * address comments Signed-off-by: lhy1024 <[email protected]> * fix lint Signed-off-by: lhy1024 <[email protected]> Co-authored-by: lhy1024 <[email protected]>
…ance config in scatter range scheduler (#4106) (#4116) * This is an automated cherry-pick of #4106 Signed-off-by: ti-chi-bot <[email protected]> * fix conflict Signed-off-by: lhy1024 <[email protected]> * ref #4399 Signed-off-by: lhy1024 <[email protected]> * fix test Signed-off-by: lhy1024 <[email protected]> Co-authored-by: lhy1024 <[email protected]>
What problem does this PR solve?
close #4497
we expect the tolerance ratio in range cluster should be 2, but it doesn't take effect.
pd/server/schedulers/scatter_range.go
Line 220 in 3f53f1e
pd/server/schedulers/utils.go
Line 154 in 3f53f1e
we expect it can schedule empty region, but it can not and test can not detect
pd/server/core/region.go
Line 96 in 3f53f1e
pd/server/schedulers/balance_test.go
Lines 1103 to 1111 in 3f53f1e
What is changed and how it works?
allow empty region to be scheduled and use a sperate tolerance config in scatter range scheduler
Check List
Tests
Add scatter range scheduler
Before this pr
After this pr
Related changes
Release note