Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedulers: evict-leader supports schedule the regions with unhealthy peers #4096

Merged
merged 4 commits into from
Sep 16, 2021

Conversation

HunDunDM
Copy link
Member

@HunDunDM HunDunDM commented Sep 8, 2021

Signed-off-by: HunDunDM [email protected]

What problem does this PR solve?

close #4093

What is changed and how it works?

schedulers: evict-leader supports schedule the regions with unhealthy peers

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

`evict-leader-scheduler` supports schedule the regions with unhealthy peers.

@HunDunDM HunDunDM added component/scheduler Scheduler logic. type/bugfix This PR fixes a bug. needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. needs-cherry-pick-release-5.1 Type: Need cherry pick to release-5.1 needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 labels Sep 8, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 8, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@HunDunDM HunDunDM requested review from nolouch and disksing September 8, 2021 08:40
@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 8, 2021
@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #4096 (a278b66) into master (40b2f85) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4096      +/-   ##
==========================================
- Coverage   74.64%   74.56%   -0.08%     
==========================================
  Files         258      258              
  Lines       26329    26337       +8     
==========================================
- Hits        19653    19639      -14     
- Misses       4930     4945      +15     
- Partials     1746     1753       +7     
Flag Coverage Δ
unittests 74.56% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/evict_leader.go 75.48% <100.00%> (+0.98%) ⬆️
server/tso/local_allocator.go 71.62% <0.00%> (-6.76%) ⬇️
server/region_syncer/client.go 77.46% <0.00%> (-4.23%) ⬇️
server/tso/tso.go 61.36% <0.00%> (-3.98%) ⬇️
pkg/etcdutil/etcdutil.go 84.70% <0.00%> (-3.53%) ⬇️
client/base_client.go 81.52% <0.00%> (-2.18%) ⬇️
server/tso/allocator_manager.go 66.50% <0.00%> (-1.50%) ⬇️
server/server.go 71.40% <0.00%> (-1.20%) ⬇️
server/config/persist_options.go 91.53% <0.00%> (-0.77%) ⬇️
server/grpc_service.go 47.05% <0.00%> (-0.23%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40b2f85...a278b66. Read the comment docs.

Signed-off-by: HunDunDM <[email protected]>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 8, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 14, 2021
@HunDunDM
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a278b66

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 16, 2021
@HunDunDM
Copy link
Member Author

/run-unit-test

1 similar comment
@HunDunDM
Copy link
Member Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 3b6d07b into tikv:master Sep 16, 2021
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 16, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4130.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4131.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4132.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4133.

@HunDunDM HunDunDM deleted the evict-leader-down-peer branch September 16, 2021 10:08
ti-chi-bot added a commit that referenced this pull request Oct 13, 2021
… peers (#4096) (#4132)

* schedulers: evict-leader supports schedule the regions with unhealthy peers

Signed-off-by: HunDunDM <[email protected]>

* tiny fix

Signed-off-by: HunDunDM <[email protected]>

* tiny fix

Signed-off-by: HunDunDM <[email protected]>

Co-authored-by: HunDunDM <[email protected]>
Co-authored-by: ShuNing <[email protected]>
hzh0425 pushed a commit to hzh0425/pd that referenced this pull request Nov 16, 2021
… peers (tikv#4096)

* schedulers: evict-leader supports schedule the regions with unhealthy peers

Signed-off-by: HunDunDM <[email protected]>

* tiny fix

Signed-off-by: HunDunDM <[email protected]>

* tiny fix

Signed-off-by: HunDunDM <[email protected]>
Signed-off-by: hzh0425 <[email protected]>
HunDunDM added a commit to ti-chi-bot/pd that referenced this pull request Nov 24, 2021
HunDunDM added a commit to ti-chi-bot/pd that referenced this pull request Nov 24, 2021
ti-chi-bot added a commit that referenced this pull request Nov 24, 2021
nolouch pushed a commit that referenced this pull request Nov 30, 2021
… peers (#4096) (#4131)

* This is an automated cherry-pick of #4096

Signed-off-by: ti-chi-bot <[email protected]>
HunDunDM added a commit to ti-chi-bot/pd that referenced this pull request Dec 1, 2021
HunDunDM added a commit to ti-chi-bot/pd that referenced this pull request Dec 1, 2021
ti-chi-bot added a commit that referenced this pull request Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/scheduler Scheduler logic. needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. needs-cherry-pick-release-5.1 Type: Need cherry pick to release-5.1 needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

evict-leader may leave leaders when the cluster has down-peers
4 participants