-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[close #333] update client-go version to fix context leak #332
Conversation
Signed-off-by: Ping Yu <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
================================================
- Coverage 61.0409% 60.9029% -0.1381%
================================================
Files 240 240
Lines 20270 20334 +64
================================================
+ Hits 12373 12384 +11
- Misses 6777 6828 +51
- Partials 1120 1122 +2
*This pull request uses carry forward flags. Click here to find out more.
|
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
02c1418
to
3b8afb1
Compare
/run-integration-test |
1 similar comment
/run-integration-test |
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
/run-integration-test |
2 similar comments
/run-integration-test |
/run-integration-test |
Signed-off-by: Ping Yu <[email protected]>
/run-integration-test |
/run-integration-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
Signed-off-by: Ping Yu [email protected]
What problem does this PR solve?
Issue Number: close #333
Problem Description: Memory leak
What is changed and how does it work?
Update
client-go
version which has fixed this issue.See tikv/client-go#697
Changes on
client-go
PR: pingyu/client-go#1
Diff: https://github.com/pingyu/client-go/compare/6ec40fff4e31..74fe33153943
Cherry-pick:
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
Related changes
To reviewers
Please follow these principles to check this pull requests:
(The above text mainly refers to TiDB Development Guide. It's also highly recommended to read about Writing code review comments)