-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update grpc 1.46.5 #593
Update grpc 1.46.5 #593
Conversation
Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
This reverts commit 49347cd. Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
This reverts commit f2a52ae. Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
The benchmark results are a little confusing. I assume "Diff (engine)" is the latency comparison between two versions with the specific engine type. Then why can we still test epollex when it is removed from 1.46.5? |
The diff is throughput difference. Diff (epollex) compares 1.46.5(epoll1) with 1.44.0(epollex), diff (epoll1) compares 1.46.5(epoll1) with 1.44.0(epoll1). Testing both two results to show that major regression is from engine change. Giving that there is a high risk of regression, but my benchmark of current TiKV using 1.44.0 and epoll1 has no obvious regression, and even some improvement under certain benchmark type(like bank). That is also part of reason why I want to upgrade grpc and check for more serious benchmark types. |
let mut creds = ServerCredentials::from_raw( | ||
grpcio_sys::grpc_ssl_server_credentials_create_with_options(opt), | ||
); | ||
creds._fetcher = Some(Box::from_raw(fetcher_wrap_ptr)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_fetcher
isn't fully gated with _secure
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, grpc c core will not delete it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, you mean whether it can be accessed in "credentials.rs". Yes, it can. The file is also feature gated by "_secure".
Signed-off-by: Jay Lee <[email protected]>
1.46.x is the last patch that support C++-11. So update to this version first.
1.46.x has removed epollex engine, which causes regression. And 1.46.x also introduce transparent retry, which can hurt client streaming throughput. The benchmark is run with transparent retry disabled.