-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tikv:move split region request to pd #459
Conversation
would you like to explain why do you want to move it to using PD? |
we are working in this issue,In Tikv,In tikv, it does not have the ability to check the current condition of the region, leading to the problem of unstable splitting. We move it to pd which having the global state of the region will reduce the probability of the problem in the above issue |
I updated the description of the PR,PTAL |
It seems that the integration tests (run with tikv) are failed. |
890e414
to
a3ed4bb
Compare
Sorry, I can't run integration tests locally,Because the tidb package is not available to me |
I change pd.RegionSplit like tikv.RegionSplit,please try to run it |
292a2c1
to
e91f54a
Compare
Signed-off-by: qidi1 <[email protected]>
Hi @qidi1 , would like to fix the lint warnings? (some of them can be fixed by merging master) |
Hi, it is nearly mergable! but there is still a lint warning:
|
Signed-off-by: qidi1 <[email protected]>
OK, I have changed |
Thanks @qidi1 |
This reverts commit aeec0c0.
This reverts commit aeec0c0. Signed-off-by: disksing <[email protected]>
This reverts commit aeec0c0.
Signed-off-by: qidi1 [email protected]
What problem does this PR solve?
Issue Number: tikv/pd/issues/4095
Proposal PR: pingcap/tidb/pull/33664
The original region split and scatter are handled by tikv and pd respectively, in order to improve efficiency, the split is also changed to be handled and controlled by PD.
What is changed and how it works?
In SplitRegions function,Using split api provide by PD instead of TiKV
Code changes based on this work
Thanks to hzh0435
Check List
Tests
Code changes
Side effects