Fix the problem that statement being oom-killed within DoneAggressiveLocking causing the transaction still in aggressive locking state #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essiveLocking causing the transaction still in aggressive locking state Signed-off-by: MyonKeminta <[email protected]>
ekexium
approved these changes
May 30, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
cfzjywxk
reviewed
May 30, 2024
| @@ -957,6 +957,11 @@ func (txn *KVTxn) CancelAggressiveLocking(ctx context.Context) { | |||
| if txn.aggressiveLockingContext == nil { | |||
| panic("Trying to cancel aggressive locking while it's not started") | |||
| } | |||
|
|
|||
| defer func() { | |||
There was a problem hiding this comment.
We could add some comments about it, maybe we could restore it after the more elegant solution is merged.
Signed-off-by: MyonKeminta <[email protected]>
cfzjywxk
approved these changes
May 30, 2024
13 tasks
ti-chi-bot
added
the
needs-cherry-pick-release-7.5
13 tasks
MyonKeminta
added a commit
to MyonKeminta/client-go
that referenced
this pull request
Jul 16, 2024
…Locking causing the transaction still in aggressive locking state (tikv#1355) * Quick fix the problem that statement being oom-killed within DoneAggressiveLocking causing the transaction still in aggressive locking state Signed-off-by: MyonKeminta <[email protected]> * Add comments to explain the change Signed-off-by: MyonKeminta <[email protected]> --------- Signed-off-by: MyonKeminta <[email protected]> Co-authored-by: MyonKeminta <[email protected]>
cfzjywxk
pushed a commit
that referenced
this pull request
Jul 16, 2024
…Locking causing the transaction still in aggressive locking state (#1355) (#1390) * Quick fix the problem that statement being oom-killed within DoneAggressiveLocking causing the transaction still in aggressive locking state * Add comments to explain the change --------- Signed-off-by: MyonKeminta <[email protected]> Co-authored-by: MyonKeminta <[email protected]>
13 tasks
MyonKeminta
added a commit
to MyonKeminta/client-go
that referenced
this pull request
Aug 1, 2024
…Locking causing the transaction still in aggressive locking state (tikv#1355) * Quick fix the problem that statement being oom-killed within DoneAggressiveLocking causing the transaction still in aggressive locking state Signed-off-by: MyonKeminta <[email protected]> * Add comments to explain the change Signed-off-by: MyonKeminta <[email protected]> --------- Signed-off-by: MyonKeminta <[email protected]> Co-authored-by: MyonKeminta <[email protected]>
cfzjywxk
pushed a commit
that referenced
this pull request
Aug 1, 2024
…Locking causing the transaction still in aggressive locking state (#1355) (#1412) * Quick fix the problem that statement being oom-killed within DoneAggressiveLocking causing the transaction still in aggressive locking state * Add comments to explain the change --------- Signed-off-by: MyonKeminta <[email protected]> Co-authored-by: MyonKeminta <[email protected]>
13 tasks
MyonKeminta
added a commit
to MyonKeminta/client-go
that referenced
this pull request
Nov 8, 2024
…Locking causing the transaction still in aggressive locking state (tikv#1355) * Quick fix the problem that statement being oom-killed within DoneAggressiveLocking causing the transaction still in aggressive locking state Signed-off-by: MyonKeminta <[email protected]> * Add comments to explain the change Signed-off-by: MyonKeminta <[email protected]> --------- Signed-off-by: MyonKeminta <[email protected]> Co-authored-by: MyonKeminta <[email protected]>
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Nov 8, 2024
…Locking causing the transaction still in aggressive locking state (#1355) (#1487) Co-authored-by: MyonKeminta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix to avoid the transaction being left in aggressive locking state after panicking in
DoneAggressiveLocking. While I haven't decide how to fix it in the most elegant approach, there should be a quick fix to avoid the problem, so that we have time to find the final solution more carefully.Ref: pingcap/tidb#53540 (comment) , pingcap/tidb#53540 (comment)